Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39621 )
Change subject: util/bincfg: Add DDR4 SPD spec
......................................................................
Patch Set 3:
Patch Set 3:
(2 comments)
hmm, first i pushed the patch from private downstream repo without the newline at the end and buildbot complained "has no final newline". then i added one newline at the end of the two files and buildbot complained "has multiple final newlines". this is odd
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39621
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic62868d59e075fd6816d7be55cc935e3e3f82499
Gerrit-Change-Number: 39621
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 17 Mar 2020 22:56:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment