[coreboot-gerrit] Change in coreboot[master]: amd/picasso: Load x86 microcode from CBFS modules

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )

Change subject: amd/picasso: Load x86 microcode from CBFS modules
......................................................................

Patch Set 17:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41719/17/src/soc/amd/picasso/update... 
File src/soc/amd/picasso/update_microcode.c:

https://review.coreboot.org/c/coreboot/+/41719/17/src/soc/amd/picasso/update... 
PS17, Line 84: if (equivalent_processor_rev_id == 0) {
             : 		printk(BIOS_DEBUG, "microcode: rev id not found. Skipping microcode patch!\n");
             : 		return;
             : 	}
unneeded check, since the lookup table is gone

https://review.coreboot.org/c/coreboot/+/41719/17/src/soc/amd/picasso/update... 
PS17, Line 92: BIOS_DEBUG
I'd rather use BIOS_WARNING or BIOS_INFO here