JasonX Z Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30795 )
Change subject: mb/google/atlas: Enable camera module NVM
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/30795/5/src/mainboard/google/poppy/variants/...
File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl:
https://review.coreboot.org/#/c/30795/5/src/mainboard/google/poppy/variants/...
PS5, Line 37: CTXS (EN_CAM_PMIC_RST_L)
: STXS (EN_PP3300_DX_CAM)
: Sleep(3)
: STXS (EN_CAM_PMIC_RST_L)
: STXS (EN_CAM_CLOCK)
: Sleep(2);
the power resource is common for CAM0 and NVM0, do you need all these steps to just to activate NVM? […]
If remove STXS/CTXS of method(PMON), cpu can't get the nvm data anymore.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30795
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc2060c2ceb7d1a8ef490f36f484deb425a37c95
Gerrit-Change-Number: 30795
Gerrit-PatchSet: 6
Gerrit-Owner: JasonX Z Chen
jasonx.z.chen@intel.com
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: JasonX Z Chen
jasonx.z.chen@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ping-chung Chen
ping-chung.chen@intel.com
Gerrit-Reviewer: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Jan 2019 10:01:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-MessageType: comment