Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43817 )
Change subject: mb/emulation/qemu-i440fx: Remove TRACE=y from test build ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
The `TRACE=y` is there so the option gets build tested. If removed for this board, it should at least be set for another. But generally, we build test so things can get fixed and not worked around. Maybe somebody will want to try it with QEMU? and then it doesn't build... that's what we actually want to avoid.
https://review.coreboot.org/c/coreboot/+/43817/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43817/2//COMMIT_MSG@11 PS2, Line 11: no longer evaluates to constant false Should the build rely on such functions, though? Or should the if be `(CONFIG(SMP) && is_smp_boot()` instead?