build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39615 )
Change subject: sc7180: Add display hardware pipe line initialization ......................................................................
Patch Set 28:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39615/28/src/mainboard/google/trogd... File src/mainboard/google/trogdor/board.h:
https://review.coreboot.org/c/coreboot/+/39615/28/src/mainboard/google/trogd... PS28, Line 22: (CONFIG(BOARD_GOOGLE_LAZOR) && board_id() < 1) ? \ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/28/src/mainboard/google/trogd... PS28, Line 22: (CONFIG(BOARD_GOOGLE_LAZOR) && board_id() < 1) ? \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39615/28/src/mainboard/google/trogd... PS28, Line 23: GPIO(106) : GPIO(30)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39615/28/src/mainboard/google/trogd... PS28, Line 23: GPIO(106) : GPIO(30)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39615/28/src/mainboard/google/trogd... File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39615/28/src/mainboard/google/trogd... PS28, Line 85: if(mdss_dsi_config(edid, lanes, dsi_bpp)) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39615/28/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/mdss.c:
https://review.coreboot.org/c/coreboot/+/39615/28/src/soc/qualcomm/sc7180/di... PS28, Line 147: /* VBIF QOS Rempaper defualt hw settings for all read/write clients */ 'defualt' may be misspelled - perhaps 'default'?