[coreboot-gerrit] [M] Change in coreboot[main]: mb/google/skyrim: Combine the function port_descriptors for variants

[Bao Zheng (Code Review)]

Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth, Matt DeVillier, Matt DeVillier, Paul Menzel, Zheng Bao.

Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/83646?usp=email )

Change subject: mb/google/skyrim: Combine the function port_descriptors for variants
......................................................................

Patch Set 4:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/83646/comment/c46bf726_2d6cd197?usp... :
PS1, Line 8:
> Please elaborate.

Done

https://review.coreboot.org/c/coreboot/+/83646/comment/a28ec220_1390c505?usp... :
PS1, Line 9: BUG=b:346716300
> I don't understand how this change relates to this bug

Done

File src/mainboard/google/skyrim/variants/baseboard/port_descriptors_combo.c:

PS1:
> Agree that having duplicate code is not a good thing.  I am a little hesitant about this change. […]

Done