Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34662 )
Change subject: Documentation/binaries: Add AMD FSP documentation
......................................................................
Patch Set 12:
(1 comment)
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34662/11/Documentation/binaries/amd...
File Documentation/binaries/amd/AMD_FSP_family_17h.md:
https://review.coreboot.org/c/coreboot/+/34662/11/Documentation/binaries/amd...
PS11, Line 23: already enabled.
Ack
Just make a clear distinction, I think start of romstage would be a natural boundary where FSP documentation begins. Any details you write here about bootblock or PSP directory becomes redundant (and possibly out-of-sync) once the situation about PSP documentation improves.
I'd be happy if you just stated "For these platforms, romstage executes from DRAM. Phases prior to romstage are described in XXXX.md" and remove the bootblock details here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59a5d34df93cd0ff647e2ccfdbf8700b4df00a59
Gerrit-Change-Number: 34662
Gerrit-PatchSet: 12
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kerry Brown
kerry.brown@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 28 Aug 2019 13:29:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment