[coreboot-gerrit] Change in coreboot[master]: nb/intel/nehalem: Disable PEG and IGD based on devicetree

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35744 )

Change subject: nb/intel/nehalem: Disable PEG and IGD based on devicetree
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35744/4/src/northbridge/intel/nehal... 
File src/northbridge/intel/nehalem/northbridge.c:

https://review.coreboot.org/c/coreboot/+/35744/4/src/northbridge/intel/nehal... 
PS4, Line 247: 	pci_write_config32(dev, D0F0_DEVEN, reg);
> > I don't like read-modify-write split like this for register D0F0_DEVEN, and having to re-initialis […]

Just use a different variable name for 0:0.0. You could even use some pci_update() variant here if you really wanted to.

I think chip_ops->init would run before PCI enumeration.