Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36328 )
Change subject: [RFC] Documentation/fsp: Discuss FSP-S issues ......................................................................
Patch Set 2:
(7 comments)
Integrated most of the comments and added some more... I think it's a little long now to be read by responsible folks :-/ anyway, I've pandoc'ed a .docx for convenient sharing with management.
https://review.coreboot.org/c/coreboot/+/36328/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36328/1//COMMIT_MSG@15 PS1, Line 15: Feel free to amend this commit in any way :)
I guess a "fsp-t_discussion. […]
Ack. Please rant about FSP-T in a separate document. While it's easy to avoid FSP-T in a product, all the ugly friction within the community could have been avoided by documenting it, I guess. So there is definitely more that Intel could do better (beside calling off their dogs).
https://review.coreboot.org/c/coreboot/+/36328/1/Documentation/fsp/fsp-s_dis... File Documentation/fsp/fsp-s_discussion.md:
https://review.coreboot.org/c/coreboot/+/36328/1/Documentation/fsp/fsp-s_dis... PS1, Line 42:
I wrote this: […]
Integrated somehow.
https://review.coreboot.org/c/coreboot/+/36328/1/Documentation/fsp/fsp-s_dis... PS1, Line 43:
Fixing bugs by binary patching or live patching is prohibited by the license
Ack
https://review.coreboot.org/c/coreboot/+/36328/1/Documentation/fsp/fsp-s_dis... PS1, Line 56:
On at least Skylake, configuring the bus/device/function for the HPET or the IOAPIC (related to VT-d […]
Added a few lines about unnecessary complex options.
https://review.coreboot.org/c/coreboot/+/36328/1/Documentation/fsp/fsp-s_dis... PS1, Line 102: POSTBOOT_SAI
I can talk about it. […]
Done
https://review.coreboot.org/c/coreboot/+/36328/1/Documentation/fsp/fsp-s_dis... PS1, Line 128: function pointers I consider the console as an optional feature. And yeah, if somebody has legal concerns, they can just stub it out.
Could you give some examples (mainly console + AP PPI, I guess) here?
Done
https://review.coreboot.org/c/coreboot/+/36328/1/Documentation/fsp/fsp-s_dis... PS1, Line 165: at least clear existing documentation for older platforms from NDAs.
Github: Intel ignores new issues for months and then closes existing issues without a) willing to fi […]
I've integrated some of this under Patrick's heading `Missing Communication and Responsibility`. Not all of it, though, I want to keep it about FSP and a general complaint about some individual's behaviour.