Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31591 )
Change subject: soc/mediatek/mt8183: Add DSI driver
......................................................................
Patch Set 48:
(2 comments)
https://review.coreboot.org/c/coreboot/+/31591/47/src/soc/mediatek/common/in...
File src/soc/mediatek/common/include/soc/dsi_common.h:
https://review.coreboot.org/c/coreboot/+/31591/47/src/soc/mediatek/common/in...
PS47, Line 69: u32 dsi_lfr_con;
nit: add comment which registers are only available since 8183?
Done
https://review.coreboot.org/c/coreboot/+/31591/47/src/soc/mediatek/mt8183/ds...
File src/soc/mediatek/mt8183/dsi.c:
https://review.coreboot.org/c/coreboot/+/31591/47/src/soc/mediatek/mt8183/ds...
PS47, Line 59: 26
Is this related to CLK26M_HZ? If so, please use that constant for clarity.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31591
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic413f524ca0b36f0b01f723a71fe9745e2710cd2
Gerrit-Change-Number: 31591
Gerrit-PatchSet: 48
Gerrit-Owner: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 12 Aug 2019 04:27:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment