Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31822 )
Change subject: soc/intel/braswell/acpi/lpc.asl: Allocate used ROM size only
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31822/2/src/soc/intel/braswell/acpi/lpc.asl
File src/soc/intel/braswell/acpi/lpc.asl:
https://review.coreboot.org/#/c/31822/2/src/soc/intel/braswell/acpi/lpc.asl@...
PS2, Line 48: ((CONFIG_COREBOOT_ROMSIZE_KB*1024) + 1),
was this really tested? the parentheses look wrong
Yes, tested and working.
Please not that this is part of second argement which is
0xffffffff - ((CONFIG_COREBOOT_ROMSIZE_KB*1024) + 1). This contains twice '(' and twice ')'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31822
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a47bf2600f546271c5a65641d29f868ff2748bf
Gerrit-Change-Number: 31822
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 24 Apr 2019 05:35:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment