Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39018 )
Change subject: ec/google/chromeec: Introduce SKU_ID helpers ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/ec_s... File src/ec/google/chromeec/ec_skuid.c:
https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/ec_s... PS4, Line 34: google_chromeec_smbios_system_sku
Yes, to get rid of the wrapping indirect, what I was saying is that the the function is named with […]
I agree, it is simple. I just rather unblock the immediate problem however I will most definitely follow up with cleanups. The current series is needed any way to have intermediate steps that are buildable for boards to be migrated as separate patches. A final patch is needed to collapse it all down to a rename, I will get to it ASAP.
https://review.coreboot.org/c/coreboot/+/39018/7/src/ec/google/chromeec/ec_s... File src/ec/google/chromeec/ec_skuid.c:
https://review.coreboot.org/c/coreboot/+/39018/7/src/ec/google/chromeec/ec_s... PS7, Line 2: *
Use SPDX-License?
Done
https://review.coreboot.org/c/coreboot/+/39018/7/src/ec/google/chromeec/ec_s... PS7, Line 4: Inc
LLC
Ack
https://review.coreboot.org/c/coreboot/+/39018/7/src/ec/google/chromeec/ec_s... PS7, Line 25: static
MAYBE_STATIC_NONZERO since this is added to early stages as well.
Done