HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45654 )
Change subject: soc/intel/cannonlake: Align gpio_op.asl with TGL
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45654/3/src/soc/intel/cannonlake/ac...
File src/soc/intel/cannonlake/acpi/gpio_op.asl:
https://review.coreboot.org/c/coreboot/+/45654/3/src/soc/intel/cannonlake/ac...
PS3, Line 47: VAL0 = PAD_CFG0_TX_STATE | VAL0
VAL0 |= PAD_CFG0_TX_STATE
https://review.coreboot.org/c/coreboot/+/45654/3/src/soc/intel/cannonlake/ac...
PS3, Line 61: VAL0 = ~PAD_CFG0_TX_STATE & VAL0
VAL0 &= ~PAD_CFG0_TX_STATE
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45654
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78d712eeba56b9c098dc6a6f11e4e51cb2529b10
Gerrit-Change-Number: 45654
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Thu, 24 Sep 2020 11:55:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment