Attention is currently required from: Paul Menzel, Stefan Reinauer, Julius Werner, Arthur Heymans.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54385 )
Change subject: Documentation: Add proposal to allow enabling serial console with a flag
......................................................................
Patch Set 4:
(1 comment)
File Documentation/technotes/2021-05-selectable-serial-console.md:
https://review.coreboot.org/c/coreboot/+/54385/comment/58ed27c0_c17b8ffd
PS4, Line 127: To avoid adding complexity in the bootblock, bootblock is exempt from
: this: When enabling this mode, bootblock stage code will not send data
: to serial for performance reason
Yes. […]
No, I think this is fine. I was slightly confused by the statement: "When enabling this mode, bootblock stage will not send data to serial for performance reason". I wanted to make sure mode here meant the Kconfig being selected. Read this section again and it makes sense to me now. Thanks for confirming!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54385
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1b0efc55880095f9d5d6d6e448f2c8677d57ff5
Gerrit-Change-Number: 54385
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 04 Jun 2021 13:19:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment