Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37185 )
Change subject: nb/intel/sandybridge: Fix mrc.bin path
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37185/1/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/37185/1/src/northbridge/intel/sandy...
PS1, Line 79: The amount of BSP stack anticipated in bootblock and
Good point, please mention it in the commit message.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37185
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic422980ca1a0549b6937e30a433ce52e0d7a595c
Gerrit-Change-Number: 37185
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 25 Nov 2019 09:51:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment