Attention is currently required from: Raul Rangel, Paul Menzel, Karthik Ramasubramanian.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57313 )
Change subject: mb/google/guybrush: Set eSPI alert as dedicated open drain
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57313/comment/67bf09d7_d181e949
PS1, Line 7: nipperkin
mb/google/guybrush/var/nippekin:
Done
File src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/57313/comment/84c1a1ae_f3fb9596
PS1, Line 37: alert_pin = ESPI_ALERT_PIN_OPEN_DRAIN,
This makes sense. I will update the CL.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57313
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b23bfc6a1167aebfde5acd524fda043b63163dc
Gerrit-Change-Number: 57313
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 02 Sep 2021 15:50:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment