[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/apollolake: Add GLK usb2eye configuration override

[Seunghwan Kim (Code Review)]

Seunghwan Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31060 )

Change subject: soc/intel/apollolake: Add GLK usb2eye configuration override
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/31060/2/src/soc/intel/apollolake/chip.c 
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/#/c/31060/2/src/soc/intel/apollolake/chip.c@554 
PS2, Line 554: if (!cfg->usb2eye[port].Usb20OverrideEn)
             : 			continue;
> Why is this check required? In case the values are not set, FSP UPDs would be set to 0 and that shou […]

I thought someone may want to override to 0 value from not zero.
Do you think we don't have to care about overriding to 0?

https://review.coreboot.org/#/c/31060/2/src/soc/intel/apollolake/chip.c@567 
PS2, Line 567:
> One blank line should be sufficient.

Done