12 May
2019
12 May
'19
5:07 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30939 )
Change subject: nb/intel/pineview: Move to C_ENVIRONMENT_BOOTBLOCK ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/30939/2/src/mainboard/foxconn/d41s/romstage.... File src/mainboard/foxconn/d41s/romstage.c:
https://review.coreboot.org/#/c/30939/2/src/mainboard/foxconn/d41s/romstage.... PS2, Line 27:
Any downside to enable all default LPC decode ranges in a common place? Haswell does that.
No downsides afaict, as long as the allocator is made aware.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30939
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e74838b0d5e9c192082084cfd9821996f0e4c50
Gerrit-Change-Number: 30939
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 12 May 2019 12:07:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment