Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45746/5/util/mainboard/google/volte...
File util/mainboard/google/volteer/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/5/util/mainboard/google/volte...
PS5, Line 5: ddr4
FYI, Volteer can be either LPDDR4x or DDR4. We are probably ok here as the SPD for an LPDDR4x and an SPD for DDR4 are the same size. Can we use a common name that doesn't imply ddr4 for the empty spd filename?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45746
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06dfb6103701bf8949180595f1e98fac48bcc585
Gerrit-Change-Number: 45746
Gerrit-PatchSet: 5
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 01 Oct 2020 20:22:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment