Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48858 )
Change subject: soc/intel/apollolake: Fix FSP/GOP display init
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48858/1/src/soc/intel/apollolake/gr...
File src/soc/intel/apollolake/graphics.c:
https://review.coreboot.org/c/coreboot/+/48858/1/src/soc/intel/apollolake/gr...
PS1, Line 65: if (CONFIG(RUN_FSP_GOP))
: return;
What we need is a RMW for PCH_PP_CONTROL and BXT_BLW_PWM_CTL. I'll
try to test things on APL later.
I forgot how much work it is to integrate APL coreboot into the IFWI. Maybe
next year.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48858
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifdc3591b714205e864cd1d0db0897d43bd6616a2
Gerrit-Change-Number: 48858
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Wed, 23 Dec 2020 19:31:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment