Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39838 )
Change subject: lp/drivers/usb: Workaround QEMU XHCI register issue ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
(1 comment)
See paragraph #4 in the bug, the fix does not work.
Oops I mean paragraph #3:
The xhci register specifies today that its allowed for users to do 1-4 byte reads; however, that it implements only four byte reads in its implementation (http://git.qemu.org/?p=qemu.git;a=blob;f=hw/usb/hcd-xhci.c;hb=HEAD#l3333). Hence why when we read the HCIVERSION register at offset 0x2, it isn't handled in xhci_cap_read() which then returns zeros.