Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38715 )
Change subject: mb/google/volteer: use new tigerlake memory config ......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38715/13/src/mainboard/google/volte... File src/mainboard/google/volteer/romstage.c:
https://review.coreboot.org/c/coreboot/+/38715/13/src/mainboard/google/volte... PS13, Line 25: lpddr4x_spd_info spd_info?
https://review.coreboot.org/c/coreboot/+/38715/13/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/baseboard/memory.c:
https://review.coreboot.org/c/coreboot/+/38715/13/src/mainboard/google/volte... PS13, Line 13: /* DQ byte map */ nit: redundant comment.
https://review.coreboot.org/c/coreboot/+/38715/13/src/mainboard/google/volte... PS13, Line 45: variant_memory_params __weak so that variant can provide its own config if required.