15 Jan
2019
15 Jan
'19
2:10 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29475 )
Change subject: drivers/i2c/nct7802y: Add new hardware-monitoring IC ......................................................................
Patch Set 3:
(1 comment)
Felix, thanks for your feedback. We currently try to get the whole series build tested, first. I'll come back to your comments later.
https://review.coreboot.org/#/c/29475/1/src/drivers/i2c/nct7802y/nct7802y.h File src/drivers/i2c/nct7802y/nct7802y.h:
https://review.coreboot.org/#/c/29475/1/src/drivers/i2c/nct7802y/nct7802y.h@... PS1, Line 39: << 0
the << 0 isn't really needed here and in the 3 lines below. […]
Just to align things and make it more visible that it's a bit mask.
--
To view, visit https://review.coreboot.org/c/coreboot/+/29475
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35ea79e12941804e398c6304a08170a776f4ca76
Gerrit-Change-Number: 29475
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Jan 2019 14:10:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment