Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42289 )
Change subject: soc/intel/xeon_sp: Enable PMC support
......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42289/6/src/soc/intel/xeon_sp/pmc.c
File src/soc/intel/xeon_sp/pmc.c:
https://review.coreboot.org/c/coreboot/+/42289/6/src/soc/intel/xeon_sp/pmc.c...
PS6, Line 11: console
move up to be in alphabetical order
Done
https://review.coreboot.org/c/coreboot/+/42289/6/src/soc/intel/xeon_sp/pmc.c...
PS6, Line 21: #if defined(__SIMPLE_DEVICE__)
This file will be built in SMM at some point, that's why there's so many guards. […]
Done
https://review.coreboot.org/c/coreboot/+/42289/6/src/soc/intel/xeon_sp/pmc.c...
PS6, Line 27: dev
PCH_DEV_PMC
Done
https://review.coreboot.org/c/coreboot/+/42289/6/src/soc/intel/xeon_sp/pmc.c...
PS6, Line 32: dev
PCH_DEV_PMC
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42289
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d57a8282a8b6dc4314f156c39deb09535575cbd
Gerrit-Change-Number: 42289
Gerrit-PatchSet: 6
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Sep 2020 16:21:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment