Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45329/7/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45329/7/src/mainboard/google/dedede...
PS7, Line 51: register "cio2_lanes_used" = "{1,4}"
shouldn't this be as follows ?
register "cio2_lanes_used" = "{2}"
The second entry is not required since we do not have the second camera on MIPI
also "cio2_lanes_used" defines the "data-lanes" entry under EP
Shouldn't it be 2 data lanes for OVTI5675 ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45329
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica6aa8ddc03a1dab5b548a759825dd3a4de3101f
Gerrit-Change-Number: 45329
Gerrit-PatchSet: 7
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Comment-Date: Wed, 23 Sep 2020 07:35:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment