Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45943 )
Change subject: vc/amd/fsp: Update bl_errorcodes_public.h ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45943/2/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/fch.c:
https://review.coreboot.org/c/coreboot/+/45943/2/src/soc/amd/picasso/psp_ver... PS2, Line 127: (uint32_t) I'm not seeing why these casts were necessary
https://review.coreboot.org/c/coreboot/+/45943/2/src/vendorcode/amd/fsp/pica... File src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_errorcodes_public.h:
https://review.coreboot.org/c/coreboot/+/45943/2/src/vendorcode/amd/fsp/pica... PS2, Line 3: * Copyright (c) 2020, Advanced Micro Devices, Inc.
does this need a dual date Copyright? (e.g. 2019-2020) I see both styles in coreboot.
I'm kind of a meh on using 2019. This file first showed up in the coreboot source in 2020. And looking at various versions of this file (as delivered), AMD has not been diligent about the copyright date.