Michael has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44167 )
Change subject: mb/acer/m3800: add Acer Aspire M3800 desktop ......................................................................
Patch Set 5:
(5 comments)
Thank you for all your feedback! For fixing resume from S3 I added another preceding commit, though it could have been done with a simple ite_reg_write() in early_init.c as well.
https://review.coreboot.org/c/coreboot/+/44167/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44167/1//COMMIT_MSG@52 PS1, Line 52: S3 suspend/resume ("RAM INIT FAILURE!" on resume)
try to call `ite_enable_3vsbsw` in early_init. […]
This helped. With the 3VSBSW# pin low during S3, the +5VSB from the PSU are applied to the DDR voltage regulator.
https://review.coreboot.org/c/coreboot/+/44167/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44167/3//COMMIT_MSG@7 PS3, Line 7: [WIP] mb/acer/m3800: add Acer Aspire M3800 desktop
I added the WIP label due to a new unresolved issue with the PS/2 keyboard and 3VSB for Suspend-to-R […]
PS/2 keyboard issues fixed by correcting SuperIO GPIO settings. Suspend-to-RAM fixed.
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/Kc... File src/mainboard/acer/m3800/Kconfig:
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/Kc... PS1, Line 12: BOARD_ROMSIZE_KB_2048
Yes it does, ifdtool reports "Flash Region 2 (Intel ME): 00006000 - 000fffff"
I assume this can be left as it is and marked as resolved. Please correct me if it's too early.
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/de... File src/mainboard/acer/m3800/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/de... PS1, Line 52: superio/ite/it8720f
Most likely yes
This helped. With the 3VSBSW# pin low during S3, the +5VSB from the PSU are applied to the DDR voltage regulator.
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/ea... File src/mainboard/acer/m3800/early_init.c:
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/ea... PS1, Line 9: RCBA32(0x3414) &= ~BUC_LAND; // BUC := Backed Up Control -> LAN is enabled
This line is taken from intel/dg43gt. […]
I removed it, did a CMOS reset and tested if LAN still works after booting. All OK.