Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47095 )
Change subject: sb/intel/lynxpoint: Use common AHCI library
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47095/2/src/southbridge/intel/lynxp...
File src/southbridge/intel/lynxpoint/sata.c:
https://review.coreboot.org/c/coreboot/+/47095/2/src/southbridge/intel/lynxp...
PS2, Line 116: /* Should be configurable */
I don't plan on doing it, though.
clarification: I'll update the comment, but I don't think I'll implement this in the foreseeable future (I'd rather deduplicate the code first).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47095
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62a26d74fe78dc0158b383da9126c56746722c53
Gerrit-Change-Number: 47095
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Nov 2020 13:14:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment