Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48859 )
Change subject: ec/google/chromeec: Guard battery-related ACPI code ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48859/1/src/ec/google/chromeec/acpi... File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/48859/1/src/ec/google/chromeec/acpi... PS1, Line 266: EC_NO_BATTERY_PRESENT
Instead of adding #ifs around this, can we use CondRefOf? […]
it would appear not, if battery.asl is not compiled in / BAT0 doesn't exist - iasl throws a compilation error. Testing if I can work around by setting _STA for BAT0 to 0x0 to achieve the same result