6 Jun
2019
6 Jun
'19
5:48 p.m.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33282 )
Change subject: spi_flash: Make .read() callback optional ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33282/1/src/drivers/spi/spi_flash.c File src/drivers/spi/spi_flash.c:
https://review.coreboot.org/#/c/33282/1/src/drivers/spi/spi_flash.c@116 PS1, Line 116: sizeof(cmd) shouldn't this be cmd_len?
--
To view, visit https://review.coreboot.org/c/coreboot/+/33282
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2096a3ce619767b41b1b0c0c2b8e95b2bd90a419
Gerrit-Change-Number: 33282
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 07 Jun 2019 00:48:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment