Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33932 )
Change subject: mb/google/helios: Add ALC1011 in Device tree
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33932/1/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/helios/gpio.c:
https://review.coreboot.org/#/c/33932/1/src/mainboard/google/hatch/variants/...
PS1, Line 91: PAD_NC(GPP_H13, NONE),
from schematics I see this is interfaced from SOC to Spkr amp.
Can you try adding the register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H13)" config from devicetree
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33932
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d71e3bd2d4493d059a33023c1afe1b630181d4f
Gerrit-Change-Number: 33932
Gerrit-PatchSet: 1
Gerrit-Owner: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 01 Jul 2019 08:00:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment