Attention is currently required from: Jason Glenesk, Matt DeVillier, Paul Menzel, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74249 )
Change subject: soc/amd/phoenix/Kconfig: Prevent changes to AMD_FWM_POSITION_INDEX
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/phoenix/Kconfig:
https://review.coreboot.org/c/coreboot/+/74249/comment/f6b26fbe_54e89252
PS2, Line 310: Typically this is calculated by the ROM size, but there may
: be situations where you want to put the firmware directory
: table in a different location.
: 0: 512 KB - 0xFFFA0000
: 1: 1 MB - 0xFFF20000
: 2: 2 MB - 0xFFE20000
: 3: 4 MB - 0xFFC20000
: 4: 8 MB - 0xFF820000
: 5: 16 MB - 0xFF020000
This is the common help text for that option for other AMD SOCs. […]
Looking at the google boards that override this, they do not use any help at all, so updated to follow that style.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74249
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f720dbadf2d28a3c39daa4bd653a407be4893d0
Gerrit-Change-Number: 74249
Gerrit-PatchSet: 4
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 10 Apr 2023 16:38:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-MessageType: comment