Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39848 )
Change subject: mb/google/deltaur: Update onboard memory config ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39848/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39848/2/src/mainboard/google/deltau... PS2, Line 15: smm-y += gpio.c
remove this.
Done
https://review.coreboot.org/c/coreboot/+/39848/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/39848/2/src/mainboard/google/deltau... PS2, Line 39: #define GPIO_MEM_CH_SEL GPP_A17
This pin is NC in GPIO table. […]
This was used by lpddr implementation, Used for halfpopulated in baseboard memory.c. Do we remove half populated altogether for deltaur?
https://review.coreboot.org/c/coreboot/+/39848/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/39848/2/src/mainboard/google/deltau... PS2, Line 13: #define MEMORY_INTERLEAVED GPP_E3
Already in baseboard, not needed.
Done