Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34368 )
Change subject: amd/stoneyridge/Kconfig: Enable stage cache based on HAVE_ACPI_RESUME
......................................................................
Patch Set 2:
Patch Set 1:
Not against this, but I expect followup work to put a 'depends on HAVE_ACPI_RESUME' to any stage cache so this one is superseded soon.
NO_STAGE_CACHE is depends on !HAVE_ACPI_RESUME and all stage cache is depends on !NO_STAGE_CACHE, so i believe your concern been taken care already
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34368
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c3b3ec4642a615e17fb3dbdedca6af8ca95ea2b
Gerrit-Change-Number: 34368
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 17 Jul 2019 04:30:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment