Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46527 )
Change subject: mb/asus/f2a85-m_pro: Enable PCIe bridge 00:15.2 in AGESA
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Please remove the clutter from the commit message. It could simply
state what (I guess) we know:
mb/asus/f2a85-m_pro: Enable PCIe bridge 00:15.2 in AGESA
Enable it in AGESA but disable enumeration in coreboot. The
system hangs otherwise.
https://review.coreboot.org/c/coreboot/+/46527/3/src/mainboard/asus/f2a85-m/...
File src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb:
https://review.coreboot.org/c/coreboot/+/46527/3/src/mainboard/asus/f2a85-m/...
PS3, Line 115: and payloads hang
Do we know for sure that it's the payload that hangs and not coreboot? If not, please
just write something like:
# FIXME: System hangs if it's enumerated by coreboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46527
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1d60a212b0d249c7d8b3f8ec16baf5e93c985da
Gerrit-Change-Number: 46527
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balázs Vinarz
vinibali1@gmail.com
Gerrit-Reviewer: Denis 'GNUtoo' Carikli
GNUtoo@cyberdimension.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 17 Nov 2020 15:51:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment