Attention is currently required from: Nico Huber, Patrick Rudolph, Julius Werner, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52879 )
Change subject: arch/x86/walkcbfs.S: Use FMAP instead "cbfs master header"
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52879/comment/8e18a84b_7dbd222b
PS2, Line 7: instead
nit: instead *of*
https://review.coreboot.org/c/coreboot/+/52879/comment/345ce912_7496073d
PS2, Line 13: the cbfs master header removed.
nit: since this line is a continuation of the previous line, I'd indent it with two spaces to account for the `- ` on the previous line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52879
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibab657cc40cd5c09c3a73c54950b98ac45a98dbf
Gerrit-Change-Number: 52879
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 04 May 2021 09:57:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment