Andrew McRae has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35466 )
Change subject: drivers/wifi/generic.c: Upper case the AML WiFi name as required by spec ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35466/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35466/1//COMMIT_MSG@7 PS1, Line 7: Use upper case for ACPI WiFi name
'Uppercase the ASL Name as required by spec' […]
Ack
https://review.coreboot.org/c/coreboot/+/35466/1//COMMIT_MSG@9 PS1, Line 9: The ACPI specification requires upper case letters for the device name.
trim this indent and include the specific part of the spec to which you refer.
Ack
https://review.coreboot.org/c/coreboot/+/35466/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35466/2//COMMIT_MSG@9 PS2, Line 9: ACPI specification Version 6.0 (Section 20.2.2 Name Objects Encoding),
Again, remove indent on commit msg body. […]
Done
https://review.coreboot.org/c/coreboot/+/35466/1/src/drivers/wifi/generic.c File src/drivers/wifi/generic.c:
https://review.coreboot.org/c/coreboot/+/35466/1/src/drivers/wifi/generic.c@... PS1, Line 242: ACPI specification
I think it is helpful to cite specifically where in the ACPI specification the particular requiremen […]
Done
https://review.coreboot.org/c/coreboot/+/35466/2/src/drivers/wifi/generic.c File src/drivers/wifi/generic.c:
https://review.coreboot.org/c/coreboot/+/35466/2/src/drivers/wifi/generic.c@... PS2, Line 242: /* ACPI specification requires uppercase name */
either […]
Done