Attention is currently required from: Subrata Banik, Paul Menzel, Kyösti Mälkki, Elyes Haouas.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72132 )
Change subject: soc/intel/common: Order the different types of cores based on APIC IDs ......................................................................
Patch Set 16:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72132/comment/b2cdda9e_d2349f03 PS15, Line 7: Add code to
Redundant as patches are about code.
Ack
https://review.coreboot.org/c/coreboot/+/72132/comment/3c5601cc_037b0f8d PS15, Line 11: for c in {0..7};
Please add a blank line above.
Ack
https://review.coreboot.org/c/coreboot/+/72132/comment/32344539_bda7b3c4 PS15, Line 11: for c in {0..7}; : do : cat /sys/devices/system/cpu/cpu$c/topology/thread_siblings_list; : done
Shorter: […]
Ack
https://review.coreboot.org/c/coreboot/+/72132/comment/b3034c6e_86acaeea PS15, Line 11: for c in {0..7}; : do : cat /sys/devices/system/cpu/cpu$c/topology/thread_siblings_list; : done : 0-1 : 4 : 5 : 6 : 7 : 0-1 : 2-3 : 2-3
You could use Markdown formatting, and indent code blocks by four spaces.
Ack