build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28569 )
Change subject: riscv: add physical memory protection (PMP) support ......................................................................
Patch Set 8:
(9 comments)
https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c File src/arch/riscv/pmp.c:
https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@82 PS8, Line 82: new = (old & ~((uintptr_t)0xff << shift)) | ((cfg & 0xff) << shift); line over 80 characters
https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@87 PS8, Line 87: new = (old & ~((uintptr_t)0xff << shift)) | ((cfg & 0xff) << shift); line over 80 characters
https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@92 PS8, Line 92: new = (old & ~((uintptr_t)0xff << shift)) | ((cfg & 0xff) << shift); line over 80 characters
https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@97 PS8, Line 97: new = (old & ~((uintptr_t)0xff << shift)) | ((cfg & 0xff) << shift); line over 80 characters
https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@106 PS8, Line 106: new = (old & ~((uintptr_t)0xff << shift)) | ((cfg & 0xff) << shift); line over 80 characters
https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@111 PS8, Line 111: new = (old & ~((uintptr_t)0xff << shift)) | ((cfg & 0xff) << shift); line over 80 characters
https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@117 PS8, Line 117: die("write_pmpcfg failure!"); Prefer using '"%s...", __func__' to using 'write_pmpcfg', this function's name, in a string
https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@123 PS8, Line 123: switch(idx) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@214 PS8, Line 214: die("write_pmpaddr failure"); Prefer using '"%s...", __func__' to using 'write_pmpaddr', this function's name, in a string