Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37558 )
Change subject: soc/intel/tigerlake: Add FSP header and Fsp.fd file path for Jasper Lake
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37558/10/src/soc/intel/tigerlake/Kc...
File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37558/10/src/soc/intel/tigerlake/Kc...
PS10, Line 92: 0x10000
Is this accurate for both TGL and JSL?
No, this needs to be revised.
JSL and ICL share same stack and heap requirement, will push a separate CL.
https://review.coreboot.org/c/coreboot/+/37558/10/src/soc/intel/tigerlake/Kc...
PS10, Line 195: FSP_FD_PATH
What about this? Shouldn't this be updated as well?
Updated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37558
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66d48206a4c1c31802e85c08ab935f81f10aadbc
Gerrit-Change-Number: 37558
Gerrit-PatchSet: 11
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 16 Dec 2019 05:46:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment