Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30913 )
Change subject: mainboard/intel: Update mainboard UART Kconfig ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/30913/2/src/mainboard/intel/coffeelake_rvp/K... File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/#/c/30913/2/src/mainboard/intel/coffeelake_rvp/K... PS2, Line 1: if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVPU || BOARD_INTEL_WHISKEYLAKE_RVP || BOARD_INTEL_COFFEELAKE_RVP8 Praveen, can you please let me know on what all boards u r using legacy UART, i believe except WHL-U, u r using legacy uart for rest and in that case UART_FOR_CONSOLE number is 0 refer as 0x3f8.
Kindly let me know so, i can create wise patch
https://review.coreboot.org/#/c/30913/2/src/mainboard/intel/kblrvp/Kconfig File src/mainboard/intel/kblrvp/Kconfig:
https://review.coreboot.org/#/c/30913/2/src/mainboard/intel/kblrvp/Kconfig@1 PS2, Line 1: BOARD_INTEL_KBLRVP3 || BOARD_INTEL_KBLRVP7 || BOARD_INTEL_KBLRVP8 -same here Praveen. RVP8 and 11 are you bother right ? because client team is using 7 and 3 as i know