Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46962 )
Change subject: mb/google/hatch/jinlon: Describe the privacy_gpio ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46962/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/jinlon/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46962/1/src/mainboard/google/hatch/... PS1, Line 86: chip drivers/usb/acpi
Ah, it probably placed the privacy_gpio on the `_SB.PCI0.XHCI. […]
Yep, you need to keep the existing hierarchy (which has the RHUB under the controller)
https://review.coreboot.org/c/coreboot/+/46962/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/jinlon/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46962/2/src/mainboard/google/hatch/... PS2, Line 86: ACPI_GPIO_INPUT_ACTIVE_LOW My (limited) understanding is that this is an IRQ, would a GpioInterrupt be more appropriate?