Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42225 )
Change subject: soc/amd/picasso: Update the AMD firmware in RW-A & RW-B regions ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42225/6/src/security/vboot/Makefile... File src/security/vboot/Makefile.inc:
PS6: Please split the security/vboot changes into their own CL.
https://review.coreboot.org/c/coreboot/+/42225/6/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/42225/6/src/soc/amd/picasso/Kconfig... PS6, Line 506: depends on VBOOT_STARTS_IN_BOOTBLOCK We need the address so we can boot vboot without psp verstage.
https://review.coreboot.org/c/coreboot/+/42225/6/src/soc/amd/picasso/Makefil... File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42225/6/src/soc/amd/picasso/Makefil... PS6, Line 261: APOB_NV_SIZE=$(shell printf "0x%x" $(shell cat $(obj)/fmap.fmd | $(_GET_APOBNV_SIZE))) Can you make the APOB cleanup it's own change.