[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Reorganize memory initialization support

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39865 )

Change subject: soc/intel/tigerlake: Reorganize memory initialization support
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39865/7/src/soc/intel/tigerlake/mem... 
File src/soc/intel/tigerlake/meminit_tgl.c:

https://review.coreboot.org/c/coreboot/+/39865/7/src/soc/intel/tigerlake/mem... 
PS7, Line 101: static void init_dq_upds(FSP_M_CONFIG *mem_cfg, int byte_pair, const uint8_t *dq_byte0,
> Isn't that happening in lines 136-137? Or am I misunderstanding something?

dq_upd is local struct. The original marco is copy board_cfg to mem_cfg right?

https://review.coreboot.org/c/coreboot/+/39865/7/src/soc/intel/tigerlake/mem... 
PS7, Line 148: static void init_dqs_upds(FSP_M_CONFIG *mem_cfg, int byte_pair, uint8_t dqs_byte0,
> Isn't that happening in lines 182-183? Or am I misunderstanding something?

same above.