Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40261 )
Change subject: mb/google/volteer: Add workaround for GPIO PM on S0ix entry/exit
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40261/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/40261/4/src/mainboard/google/voltee...
PS4, Line 9: LOCL
Furquan, why did you let me get away with calling this LOCL before? 😄 LOCL was just short for "Local method" because I really couldn't come up with a better name. Maybe a better name would be PGPM (Program Gpio PM bits?). A quick grep shows that doesn't appear to be used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40261
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If522c82c0069a4bf5738beb73a2b4f11ed6f51d3
Gerrit-Change-Number: 40261
Gerrit-PatchSet: 4
Gerrit-Owner: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 15 Apr 2020 22:06:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment