Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31262 )
Change subject: soc/intel/cannonlake: Add field to identify single channel memory ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/#/c/31262/10/src/soc/intel/cannonlake/cnl_memcfg... File src/soc/intel/cannonlake/cnl_memcfg_init.c:
https://review.coreboot.org/#/c/31262/10/src/soc/intel/cannonlake/cnl_memcfg... PS10, Line 19: #include <soc/gpio.h>
I thought that this was needed for other boards. You had commented in patchset 5: […]
Yeah, that was because you had included gpio_soc_defs.h and so I had indicated that including gpio.h is the right thing to do instead of gpio_soc_defs.h. Looking at the change again, I don't see anything being added here that requires any of those header files. Is it really required?
https://review.coreboot.org/#/c/31262/10/src/soc/intel/cannonlake/cnl_memcfg... PS10, Line 53: cnl_cfg
I think that Patrick commented that the name should be the same as others below, which used the name […]
Oh okay.