Attention is currently required from: Angel Pons, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jingyuan Liang, Kapil Porwal, Kyoung Il Kim, Paul Menzel, Subrata Banik, Tarun.
Hello Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jingyuan Liang, Kapil Porwal, Kyoung Il Kim, Subrata Banik, Tarun, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81333?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: mb/google/rex: Add Intel Touch for controller 1 for Rex ......................................................................
mb/google/rex: Add Intel Touch for controller 1 for Rex
This patch enables THC1 support for Rex according to the corresponding CBI fw_config. The change includes the GPIO pad configuration and adding ACPI entries in SSDT for ELAN touch device. THC0 is also enabled when THC1 is enabled due to the design constraint.
NOTE for Rework info: - Major rework is required when using THC1 with Rex P1 and P2. Minor rework is needed for EVT.
- Rex with THC rework won't be able to support UWB and FPCMU as the original board does. And their CBI fw_config shouled be disabled to avoid conflict with THC1.
- The resistor on the THC1 THC-SPI MISO pin should be 100 Ohm.
NOTE for downstream device: - The ELAN touch device interface must be converted from I2C to SPI prior to use.
BUG=b:307775082
TEST=set CBI TOUCHSREEN fw_config to TOUCHSCREEN_THC, FP fw_config to FP_ABSENT, and UWB fw_config to UWB_ABSENT. boot Rex to OS and run lspci to check THC device and check that THC device driver initialization successfully. /sys/class/hidraw/hidraw0/device/input/ should have several inputs enumerated.
Signed-off-by: Cliff Huang cliff.huang@intel.com Change-Id: Id89b5b46d67b90491410d3d08c1a3ae9549b4da5 --- M src/mainboard/google/rex/Kconfig M src/mainboard/google/rex/variants/rex0/fw_config.c M src/mainboard/google/rex/variants/rex0/overridetree.cb 3 files changed, 163 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/81333/7