Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35822 )
Change subject: [RFC]arch/x86: Only allow normal and fallback prefix
......................................................................
Patch Set 2:
(1 comment)
I wonder if it would be hard to maintain the current Kconfig
rules for romcc bootblocks and just restrict them for C-env
ones?
https://review.coreboot.org/c/coreboot/+/35822/2/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/35822/2/src/Kconfig@50
PS2, Line 50:
Could we just add a third choice here that depends on !C_ENV
and would enable the prompt below?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35822
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04222120bd1241c3b0996afa27dcc35ac42fbbc8
Gerrit-Change-Number: 35822
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 06 Oct 2019 12:53:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment