Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34770 )
Change subject: soc/mediatek: dsi: Unify format to bpp conversion
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34770/4/src/soc/mediatek/common/dsi...
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/34770/4/src/soc/mediatek/common/dsi...
PS4, Line 128: bytes_per_pixel = mtk_dsi_get_bits_per_pixel(format) / 8;
Is this supposed to be the ceiling of the division?
For MIPI_DSI_FMT_RGB666 the result was 3 but is now 2.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34770
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd405220b73859e5592c68f498af07eef8d7edbc
Gerrit-Change-Number: 34770
Gerrit-PatchSet: 4
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-Comment-Date: Thu, 08 Aug 2019 01:49:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment