Attention is currently required from: Jeremy Soller, Tim Crawford.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80756?usp=email )
Change subject: mb/system76/adl,rpl: Add timeouts for PCIe 3.0 RPs ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80756/comment/07e1592b_8f55aa5c : PS1, Line 7: Add timeouts for PCIe 3.0 RPs : Maybe:
Add 50 ms timeouts for PCIe 3.0 RPs
https://review.coreboot.org/c/coreboot/+/80756/comment/895be8d3_31d7097f : PS1, Line 14: Tested on lemp12 with Samsung 980 PRO and 990 PRO drives. What drive firmware versions?
https://review.coreboot.org/c/coreboot/+/80756/comment/7b43751d_ea1fb68f : PS1, Line 15: Is there a default time-out value? Why 50 ms and not another value?
File src/mainboard/system76/adl/variants/darp8/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80756/comment/08282b45_21fa1e06 : PS1, Line 155: .pcie_rp_detect_timeout_ms = 50, Is there a default timeout?